-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added untracked
function
#380
Conversation
🦋 Changeset detectedLatest commit: 5c72e9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@andrewiggins I will be appreciate if you give feedback) |
Hey! One question that comes to mind for me is what use case does this help that use |
Some reasons is specified in proposal linked to the PR. const untracked = (callback) => computed(callback).peek() And I am not sure that I can modify values in computed, it feels weird |
Oh whoops! I missed the linked proposal. Lemme take a look and mull it over with the team |
I think this thing are essential for writing Store-like primitives and dealing with it without tricks |
@andrewiggins when you will return with feedback? |
I have some vacation coming up so will be away for a week or two. Though if other core team members have thoughts, no need to block on me |
@JoviDeCroock what do you think about |
This looks good to me, tests seem to be failing and needs a changeset |
Fixed |
Co-authored-by: Jovi De Croock <[email protected]>
Thanks a lot👍 |
Resolves #378
As mentioned in the proposal this allows us to write effects that essentially aren't re-executed by the signals that get accessed in the function body of
untracked
.Allowing functionality like